Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -q to the unzipping of the full Windows JDK. #17796

Closed
wants to merge 1 commit into from
Closed

Add -q to the unzipping of the full Windows JDK. #17796

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

@benjaminp benjaminp commented Mar 16, 2023 •
edited
Loading

This generated a lot of noisy stdout.

@benjaminp
Add -q to the unzipping of the full Windows JDK.
9fe6abb 
This generated a lot of noisey stdout.
@benjaminp
Copy link
Collaborator Author

@meisterT I believe this is your department. Maybe the set -x in the Windows branch can also be removed?

@meisterT
Copy link
Member

I would keep the set -x - debugging failures on windows is not fun and it has helped in the past to know what step went wrong (not too many lines anyway).

@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 17, 2023
@benjaminp benjaminp deleted the quiet-jdk branch March 17, 2023 14:52
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@benjaminp @fweikert
Add -q to the unzipping of the full Windows JDK.
bbe980e 
This generated a lot of noisy stdout.

Closes bazelbuild#17796.

PiperOrigin-RevId: 517384038
Change-Id: I5a7bcf89b5ed5cc623d60209111b2bbbea8f4994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminp @meisterT