Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2.0]Enable C++ deps pruning on Windows when PARSE_SHOWINCLUDES is available. #17957

Merged

Conversation

ShreeM01
Copy link
Contributor

@ShreeM01 ShreeM01 commented Apr 3, 2023

This fixes #14947.

Closes #17928.
Commit: 788801a
PiperOrigin-RevId: 521446074
Change-Id: I4bc155f0245bc1933e86cd0b37762263437ed1fe

This fixes bazelbuild#14947.

Closes bazelbuild#17928.

PiperOrigin-RevId: 521446074
Change-Id: I4bc155f0245bc1933e86cd0b37762263437ed1fe
@ShreeM01 ShreeM01 changed the title Enable C++ deps pruning on Windows when PARSE_SHOWINCLUDES is available. [6.2.0]Enable C++ deps pruning on Windows when PARSE_SHOWINCLUDES is available. Apr 3, 2023
@keertk keertk added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 3, 2023
@meteorcloudy
Copy link
Member

I believe the test failure is related to #17447, we should probably disable that test in the release branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants