Make --incompatible_remote_build_event_upload_respect_no_cache a no-op
#17989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
coeuvre
approved these changes
Apr 5, 2023
coeuvre
added
awaiting-PR-merge
|
Any context on the delay of this import @kshyanashree? |
Hi @brentleyjones! There were conflicts where I removed few unneeded tests. Still presubmits are failing, Could you please look into it? |
|
I'll rebase soon. |
brentleyjones
force-pushed
the
bj/make-incompatible_remote_build_event_upload_respect_no_cache-a-no-op
branch
from
8c5c3f2
to
4743c64
Compare
Thank you! |
RELNOTES: `--incompatible_remote_build_event_upload_respect_no_cache` is now a no-op.
brentleyjones
force-pushed
the
bj/make-incompatible_remote_build_event_upload_respect_no_cache-a-no-op
branch
from
4743c64
to
3448f67
Compare
brentleyjones
commented
Apr 19, 2023
Comment on lines
-760
to
-761
| || remoteOptions.remoteBuildEventUploadMode != RemoteBuildEventUploadMode.ALL | ||
| || !remoteOptions.incompatibleRemoteBuildEventUploadRespectNoCache) { |
There was a problem hiding this comment.
@coeuvre The way this was written, using one flag or the other, meant that this always evaluated to true (so always returned false). The tests are breaking with this change, and to get the hold behavior, I would instead change this to remoteOptions == null || true, or just have the function always return false.
Not sure what to do for this.
coeuvre
approved these changes
Apr 20, 2023
|
@kshyanashree all green now |
Thanks @brentleyjones! |
ShreeM01
removed
the
awaiting-PR-merge
brentleyjones
deleted the
bj/make-incompatible_remote_build_event_upload_respect_no_cache-a-no-op
branch
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Also removed unneeded tests. RELNOTES: `--incompatible_remote_build_event_upload_respect_no_cache` is now a no-op. Closes bazelbuild#17989. PiperOrigin-RevId: 526843711 Change-Id: I1305514cf39c29aca9208beb2569d725370b0179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed unneeded tests.
RELNOTES:
--incompatible_remote_build_event_upload_respect_no_cacheis now a no-op.