-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Xcode 14.3 compatibility #18460
Closed
Closed
Fix Xcode 14.3 compatibility #18460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015. Fixes bazelbuild#18278
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
May 19, 2023
sgowroji
added
the
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
label
May 22, 2023
meteorcloudy
approved these changes
May 22, 2023
@bazel-io fork 6.3.0 |
meteorcloudy
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
May 22, 2023
I don't recall specifically which error that was targeted at. But the description of that is correct that technically Xcode 14+ only supports macOS 10.13+ I just chose to be as conservative as possible here since this fixes the only error we know about now |
Pavank1992
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
May 24, 2023
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 24, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015. Fixes bazelbuild#18278 Closes bazelbuild#18460. PiperOrigin-RevId: 534743568 Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3
iancha1992
added a commit
that referenced
this pull request
May 25, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015. Fixes #18278 Closes #18460. PiperOrigin-RevId: 534743568 Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015. Fixes bazelbuild#18278 Closes bazelbuild#18460. PiperOrigin-RevId: 534743568 Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015.
Fixes #18278