Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document --experimental_output_paths #19891

Closed
wants to merge 1 commit into from
Closed

Document --experimental_output_paths #19891

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 19, 2023

No description provided.

@fmeum fmeum requested a review from a team as a code owner October 19, 2023 10:20
@fmeum fmeum requested review from sdtwigg and gregestren and removed request for a team and sdtwigg October 19, 2023 10:20
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions labels Oct 19, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 19, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 19, 2023
@keertk
Copy link
Member

keertk commented Oct 19, 2023

@bazel-io fork 7.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 19, 2023
@bazel-io bazel-io mentioned this pull request Oct 19, 2023
Closed
@iancha1992
Copy link
Member

@gregestren Is this good to be merged?

@aiuto
Copy link
Contributor

aiuto commented Oct 30, 2023

Greg is OOO for a few more days. Although this is probably correct, I'll wait a few days for him to decide if it is ready to be documented, or if there is more work to go in first.

@fmeum
Copy link
Collaborator Author

fmeum commented Oct 30, 2023

Greg is OOO for a few more days. Although this is probably correct, I'll wait a few days for him to decide if it is ready to be documented, or if there is more work to go in first.

It's been mentioned throughout our BazelCon talk and we even have the first users reporting on their experience. Would be great if we could merge this now to prevent confusion about which version has this flag.

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 30, 2023
@Wyverald
Copy link
Member

This flag was discussed in both the BazelCon talk and extensively in the remote execution BoF, so I think some documentation is warranted.

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 30, 2023
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Oct 30, 2023
@fmeum @bazel-io
Document --experimental_output_paths
8bc386f 
Closes bazelbuild#19891.

PiperOrigin-RevId: 577970043
Change-Id: Ia5e9386d6fe6e0601787ec069d9054b0b8cf1418
@bazel-io bazel-io mentioned this pull request Oct 30, 2023
Merged
@fmeum fmeum deleted the document-output-paths branch October 31, 2023 11:21
iancha1992 pushed a commit that referenced this pull request Nov 1, 2023
@bazel-io @fmeum
[7.0.0] Document --experimental_output_paths (#19993)
13ea6b4 
Closes #19891.

Commit
6191a70

PiperOrigin-RevId: 577970043
Change-Id: Ia5e9386d6fe6e0601787ec069d9054b0b8cf1418

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@gregestren gregestren Awaiting requested review from gregestren

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fmeum @keertk @iancha1992 @aiuto @Wyverald @bazel-io