[7.0.1] Fixes for Bazel's own integration tests fail locally on Linux #20821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata map. This happens for action templates. The reason is that the Linux sandbox needs to know where the tree file artifact is materialized to, which information is stored in its parent. The reason for making this a flag was performance, but it's only at most one tree artifact per action, it's a constant time operation per tree artifact and it only happens rarely (on templated actions) so I think this time, simplicity is better than performance. The surprising change to ActionInputMapHelper was needed because before this change, the tree artifact was a discovered input and therefore was processed by the code path in ActionExecutionFunction.addDiscoveredInputs(), which populated archivedTreeArtifacts but addToMap() did not. It was presumably the bug. The depOwner argument of putTreeArtifact may also be wrong there. It's at least inconsistent with the other two call sites, but I don't want to add more polish at some risk to this change so I decided to not add it to addArchivedTreeArtifactMaybe(). Progress towards bazelbuild#20753. RELNOTES: None. PiperOrigin-RevId: 596586625 Change-Id: Ib690a84508da07560ec376d4e87ed8fb2211979f
This is necessary because that paths of those directories are different when seen by Bazel and by the processes within the sandbox and the sandbox interprets paths to writable directories as within the sandbox. This is notably the case for $TEST_TMPDIR. The reason why this worked at all is that the $TEST_TMPDIR that Bazel passes to the test is relative to the working directory (it's absolutized in the test wrapper script) Progress on bazelbuild#20753. RELNOTES: None. PiperOrigin-RevId: 596566851 Change-Id: Ifb56a3016a521b6a0cd4b5700172951d6feabddf
This makes --experimental_split_coverage_postprocessing work in the wake of bazelbuild@fb6658c: before, it was enough to add the metadata of the tree file artifacts to the metadata provider of the post-processing action, but that change made the metadata of the tree artifact necessary, too. Progress towards bazelbuild#20753. RELNOTES: None. PiperOrigin-RevId: 596929659 Change-Id: I481ef36328de7f7ab07f2ec7a0ac83d5fd508c36
iancha1992
added
the
team-Local-Exec
github-actions
bot
added
awaiting-review
This was referenced Jan 9, 2024
lberki
approved these changes
Jan 9, 2024
github-actions
bot
removed
the
awaiting-review
iancha1992
pushed a commit
that referenced
this pull request
Jan 18, 2024
Baseline: d798ebd Release Notes: + Consider MODULE.bazel for workspace detection in bazel.sh (#20594) + Auto-create deploy jars for Bazel `java_test` targets if requested (#20602) + `java_binary` wrapper should forward `restricted_to` (#20611) + Mount user-specified bind mounts before Bazel's own magic. (#20609) + Fix bootstrapped Bazel binary (#20612) + Attempt to make main repo mapping inverse more efficient (#20625) + Cherry-pick all presubmit.yml changes (#20733) + Print interactive sandboxed shell command with `--sandbox_debug` (#20734) + Fix two issues with --incompatible_sandbox_hermetic_tmp that manifested themselves when the output base was under /tmp (#20718) + Let module extensions track calls to `Label()` (#20750) + Add support for bind mounts under `/tmp` with hermetic tmp (#20749) + Fixes for Bazel's own integration tests fail locally on Linux (#20821) + Fix NPE in BzlmodRepoRuleFunction (#20828) + Avoid emitting canonical labels into generated repos (#20840) + Let .bzl files record their usages of repo mapping (#20848) + Force output checking for incremental run commands without the bytes. (#20881) + Retry binding to ipv6 localhost (#20903) + Fix linker feature detection being performed on wrong linker (#20901) + Fix singlejar resource mapping for external repositories (#20904) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, David Ostrovsky, Fabian Meumertzheim, hvd, Siddhartha Bagaria, Tianyu Geng, Xdng Yng, Xùdōng Yáng.
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Baseline: d798ebd Release Notes: + Consider MODULE.bazel for workspace detection in bazel.sh (#20594) + Auto-create deploy jars for Bazel `java_test` targets if requested (#20602) + `java_binary` wrapper should forward `restricted_to` (#20611) + Mount user-specified bind mounts before Bazel's own magic. (#20609) + Fix bootstrapped Bazel binary (#20612) + Attempt to make main repo mapping inverse more efficient (#20625) + Cherry-pick all presubmit.yml changes (#20733) + Print interactive sandboxed shell command with `--sandbox_debug` (#20734) + Fix two issues with --incompatible_sandbox_hermetic_tmp that manifested themselves when the output base was under /tmp (#20718) + Let module extensions track calls to `Label()` (#20750) + Add support for bind mounts under `/tmp` with hermetic tmp (#20749) + Fixes for Bazel's own integration tests fail locally on Linux (#20821) + Fix NPE in BzlmodRepoRuleFunction (#20828) + Avoid emitting canonical labels into generated repos (#20840) + Let .bzl files record their usages of repo mapping (#20848) + Force output checking for incremental run commands without the bytes. (#20881) + Retry binding to ipv6 localhost (#20903) + Fix linker feature detection being performed on wrong linker (#20901) + Fix singlejar resource mapping for external repositories (#20904) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, David Ostrovsky, Fabian Meumertzheim, hvd, Siddhartha Bagaria, Tianyu Geng, Xdng Yng, Xùdōng Yáng.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 3 commits.
c48392c, bc1d9d3, b0db044
Progress towards #20753