Commits on Jan 12, 2024

1. Force output checking for incremental run commands without the bytes. …

   When building without the bytes, outputs are only materialized when either (1) an action prefetches them, or (2) they've been explicitly requested. When both --remote_download_minimal and --noexperimental_check_output_files are set, this presents a problem for a build command followed by a run command for the same target: the build command won't download the outputs and the run command won't check for their presence, proceeding without them. A non-incremental run command works, because the outputs are considered top-level even in minimal mode.
   
   This is only a problem for a run command because it exists outside of action execution, and doesn't get a chance to prefetch inputs; it would have been better to implement the run command by injecting a specially crafted action into the build graph, but that will have to wait for another day. The present fix might theoretically slow things down if output checking is truly unnecessary, but I doubt that would cause a significant regression in practice.
   
   Fixes bazelbuild#20843.
   
   Closes bazelbuild#20853.
   
   PiperOrigin-RevId: 597909909
   Change-Id: I66aedef4994fbda41fe5378c80940fa8ba637bfd

   

   tjgq authored and bazel-io committed Jan 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 94b07b7
   • Browse repository at this point

   Copy the full SHA

   94b07b7 View commit details

   Browse the repository at this point in the history