Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced usage of rev with awk in bash runfiles #20885

Closed

Conversation

nikhilkalige
Copy link
Contributor

Nixpkgs bazel builds restricts the set of tools that are available by default to

bash
coreutils
diffutils
file
findutils
gawk
gnugrep
gnupatch
gnused
gnutar
gzip
python3
unzip
which
zip

Using awk instead of rev reduces the need to add additional packages to the PATH

Nixpkgs bazel build restricts the set of tools that are available by default. Using
awk instead of rev reduces the need to add additional packages to the PATH
Copy link

google-cla bot commented Jan 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 13, 2024
Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meteorcloudy Could you review this as well?

@fmeum
Copy link
Collaborator

fmeum commented Jan 13, 2024

@bazel-io fork 7.1.0

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 15, 2024
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jan 16, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 18, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 18, 2024
Closes bazelbuild#20885.

PiperOrigin-RevId: 599442183
Change-Id: I4d546ebebeb9007632e51f1ec000bb2332f19cb6
@nikhilkalige nikhilkalige deleted the runfiles_coreutils_usage branch January 18, 2024 16:54
github-merge-queue bot pushed a commit that referenced this pull request Jan 19, 2024
Closes #20885.

Commit
9ae9d1d

PiperOrigin-RevId: 599442183
Change-Id: I4d546ebebeb9007632e51f1ec000bb2332f19cb6

Co-authored-by: Nikhil Kalige <Nikhil.Kalige@intusurg.com>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants