Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init_submodules to git_override #20937

Closed

Conversation

keith
Copy link
Member

@keith keith commented Jan 18, 2024

This is slightly different from the starlark version which has a separate init_submodules and recursive_init_submodules for historical reasons.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 18, 2024
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 18, 2024
This is slightly different from the starlark version which has a
separate init_submodules and recursive_init_submodules for historical
reasons.
@keith
Copy link
Member Author

keith commented Jan 19, 2024

updated to split recursive submodules into a separate bool per the convo in #20912 (comment)

@keith keith force-pushed the ks/add-init_submodules-to-git_override branch from cf61784 to a6bad1f Compare January 19, 2024 21:35
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 22, 2024
Wyverald pushed a commit that referenced this pull request Jan 26, 2024
This is slightly different from the starlark version which has a separate init_submodules and recursive_init_submodules for historical reasons.

Closes #20937.

PiperOrigin-RevId: 600337195
Change-Id: I6e26d58f442d3e2c85feee20c14017b5a13fa588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants