Commits on Feb 14, 2024

1. Watch arbitrary file in repo rules …

   * Starlark API changes
     * New method `rctx.watch()` that watches a path. As of right now, said path must exist and be a regular file, but that will change in follow-ups.
     * Existing method `rctx.read()` gets a new optional string parameter `watch` that defaults to `auto`. This causes the file read to be watched as well by default, even if it's not addressed by a label. See `rctx.read()` docs for the semantics of `watch`.
     * Both changes apply to `mctx` as well, except that no files outside the current Bazel workspace may be watched for `mctx`.
   * Marker file format changes
     * `FILE:` marker file entries can now be `FILE:` followed by either an absolute path (starts with a singular '/'), or a label-like ... thing (which is a label but has a slash in place of a colon). This is because we might be watching something inside a repo that is _not_ under a package.
     * Same change will happen to the `accumulatedFileDigests` sections of the module lockfile.
   * Code changes
     * `RepoRecordedInput.File` subclasses are renamed to `FileOutsideWorkspace` (absolute paths) and `FileInsideWorkspace` (label-like things) instead to better reflect their meaning.
     * Unified the file watching/digest checking logic in SingleExtensionEvalFunction with the RepoRecordedInput stuff. Follow-ups will unify more.
     * Moved RepoRecordedInput to its own BUILD target as it's being used outside the repo fetching machinery (namely, module extensions)
     * Since `FileOutsideWorkspace` has to be an absolute path (never relative), we don't need a "base directory" for the RepoRecordedInput parser. What we really need is just the FileSystem object, which we can get from the PathPackageLocator available in Skyframe. Refactored code to reflect that.
   
   RELNOTES: Added a new method, `repository_ctx.watch()`, which asks Bazel to watch for changes to an arbitrary file. When said file changes, Bazel will refetch the repo.
   
   Work towards #20952.

   

   Wyverald committed Feb 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 463cd52
   • Browse repository at this point

   Copy the full SHA

   463cd52 View commit details

   Browse the repository at this point in the history