Mark use_repo_rule extension as reproducible
#21304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
approved these changes
Feb 12, 2024
|
@Wyverald Tested this on a project and it didn't seem to work, please don't merge yet. |
|
@Wyverald Nvm, what I saw in the lockfiles were the usages for the repo rules, which are still in there until we adopt the new lockfile format. Ready to merge! |
github-actions
bot
added
team-ExternalDeps
|
please delete the offending obsolete test case |
Also fix two typos.
fmeum
force-pushed
the
reproducible-repo-rules
branch
from
a517b46
to
904f648
Compare
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
meteorcloudy
approved these changes
Feb 13, 2024
SalmaSamy
approved these changes
Feb 13, 2024
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 13, 2024
This ensures that the attributes of repo rules used with `use_repo_rule` are not duplicated in the locked extension entry in the lockfile. They are still duplicated in the usages section of the lockfile. Also fix two typos. Closes bazelbuild#21304. PiperOrigin-RevId: 606660953 Change-Id: I5f7fa50dbacfafae22e4ea3fdb92e6bfb2beffc6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
This ensures that the attributes of repo rules used with `use_repo_rule` are not duplicated in the locked extension entry in the lockfile. They are still duplicated in the usages section of the lockfile. Also fix two typos. Closes #21304. Commit 0523461 PiperOrigin-RevId: 606660953 Change-Id: I5f7fa50dbacfafae22e4ea3fdb92e6bfb2beffc6 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the attributes of repo rules used with
use_repo_ruleare not duplicated in the locked extension entry in the lockfile. They are still duplicated in the usages section of the lockfile.Also fix two typos.