Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Parallelize TreeArtifactValue.visitTree across files instead of subdirectories. #21347

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[7.1.0] Parallelize TreeArtifactValue.visitTree across files instead of subdirectories. #21347

merged 1 commit into from
Feb 14, 2024

Commits on Feb 14, 2024

  1. [7.1.0] Parallelize TreeArtifactValue.visitTree across files instead … 

    …of subdirectories.

This performs better when the subdirectories are unbalanced (and doesn't degrade catastrophically for a flat hierarchy). Most tree artifacts are too small for this to matter, but some users have very large ones (with hundreds of thousands of files) for which this can reduce the overall traversal time by 30% or more (after other, more important optimizations such as bazelbuild@f2512a0 have been made).

Also remove the edge case for the root directory; the code is cleaner that way.

Related to bazelbuild#17009.

PiperOrigin-RevId: 606897861
Change-Id: I143d55a844ac191543a856f73849a95560199468
    @tjgq
    tjgq committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    45f06e6 View commit details
    Browse the repository at this point in the history