[7.2.0] Implement a JNI wrapper around SQLite. #22158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by the implementation of garbage collection for the disk cache, as discussed in bazelbuild#5139 and the linked design doc. I judge this to be preferred over https://github.com/xerial/sqlite-jdbc for the following reasons: 1. It's a much smaller dependency. 2. The JDBC API is too generic and becomes awkward to use when dealing with the peculiarities of SQLite. 3. We can (more easily) compile it from source for all host platforms, including the BSDs. PiperOrigin-RevId: 628046749 Change-Id: I17bd0547876df460f48af24944d3f7327069375f
github-actions
bot
added
awaiting-review
iancha1992
approved these changes
Apr 26, 2024
Merged
via the queue into
bazelbuild:release-7.2.0
with commit Apr 26, 2024
dc87fdd
33 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by the implementation of garbage collection for the disk cache, as discussed in #5139 and the linked design doc. I judge this to be preferred over https://github.com/xerial/sqlite-jdbc for the following reasons:
PiperOrigin-RevId: 628046749
Change-Id: I17bd0547876df460f48af24944d3f7327069375f