-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up build after update to 7.2.0 #22400
Conversation
e191001
to
bf97b89
Compare
@keertk @iancha1992 FYI, I prepared this PR to verify compatibility with the new lockfile format. Happy to finalize it when 7.2.0 lands. |
Just FYI, if you change the |
Thanks, I'm in the process of setting up a Windows VM for that. But I likely need to do it again after the actual release, so I'll wait for that. |
I'd suggest you not to worry about it, and let us (me?) do the work when 7.2.0 is actually released :) I've done this multiple times now and have all four machine types on hand. |
or, actually, if we could get rules_python to declare certain module extensions of theirs to be reproducible, we might be able to just remove all traces of them from the lockfile. |
I looked into that today: Two of their extensions are trivially reproducible (bazelbuild/rules_python#1892), but the |
724a3df
to
261aba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@bazel-io fork 7.3.0 |
Closes bazelbuild#22400. PiperOrigin-RevId: 642564375 Change-Id: I1326aa33ddd30d29a51b928adcea0def42304fe9
Closes bazelbuild#22400. PiperOrigin-RevId: 642564375 Change-Id: I1326aa33ddd30d29a51b928adcea0def42304fe9
No description provided.