Path map executable paths #22844
Closed
Path map executable paths #22844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
gregestren and
justinhorvitz
and removed request for
a team and
gregestren
github-actions
bot
added
team-Performance
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should both be path mapped and turned into a "callable" path (e.g. `./tool.sh` instead of `tool.sh`). This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`. This is fixed by moving the handling of the first argument into `CommandLines`.
fmeum
force-pushed
the
executable-path-mapping
branch
from
c69935f
to
bb26cd6
Compare
|
Marking this as draft as the idea is flawed: It's possible that the user wants the executable to be looked up in path. |
fmeum
force-pushed
the
executable-path-mapping
branch
from
39ce826
to
fa05d22
Compare
fmeum
force-pushed
the
executable-path-mapping
branch
from
fa05d22
to
1e79fcb
Compare
fmeum
changed the title
|
@justinhorvitz Friendly ping |
|
Is this change only necessary due to the optimization detailed at https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java;l=979-982;drc=d32202b20f82c17f75ee204d505b08f2160640f5? That comes from d18702c, for which the internal description mentions a trivial memory savings. Maybe it's not worth it? @comius |
|
Not just because of that: There is plenty of starlark API that doesn't provide access to an |
|
Thanks, it's much easier to justify this change then. |
justinhorvitz
approved these changes
Jul 18, 2024
|
@bazel-io fork 7.3.0 |
Wyverald
added
awaiting-PR-merge
|
@justinhorvitz @fmeum Just a friendly reminder, the 7.3.0RC1 is scheduled for next Monday, July 29th. Thanks! |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 26, 2024
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`. Work towards bazelbuild#6526 Work towards bazelbuild#22366 Closes bazelbuild#22844. PiperOrigin-RevId: 656258007 Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37 Closes bazelbuild#23040
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 26, 2024
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`. Work towards bazelbuild#6526 Work towards bazelbuild#22366 Closes bazelbuild#22844. PiperOrigin-RevId: 656258007 Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37 Closes bazelbuild#23040
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`. Work towards #6526 Work towards #22366 Closes #22844. PiperOrigin-RevId: 656258007 Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37 Closes #23040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
CommandLines, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case forSpawnAction's created viactx.actions.run(executable = <some string>).Work towards #6526
Work towards #22366