Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Propagate linkopts of header-only libraries to cc_shared_library #24017

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

iancha1992
Copy link
Member

Fixes #21884
Fixes #23053

Closes #23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1

Commit 0fdb36f

Fixes bazelbuild#21884
Fixes bazelbuild#23053

Closes bazelbuild#23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
@iancha1992 iancha1992 added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 16, 2024
@iancha1992 iancha1992 changed the title Propagate linkopts of header-only libraries to cc_shared_library [7.4.0] Propagate linkopts of header-only libraries to cc_shared_library Oct 16, 2024
@iancha1992 iancha1992 marked this pull request as ready for review October 16, 2024 23:15
@iancha1992 iancha1992 requested a review from a team as a code owner October 16, 2024 23:15
@github-actions github-actions bot removed the team-Rules-CPP Issues for C++ rules label Oct 16, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into bazelbuild:release-7.4.0 with commit c118308 Oct 17, 2024
52 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 17, 2024
iancha1992 pushed a commit that referenced this pull request Oct 25, 2024
… to `cc_shared_library`" (#24087)

Reverts #24017

The change has broken multiple existing builds. Even if it can be fixed,
its usefulness does not justify the potential for more breakages in a
minor release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants