Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows,examples: //examples/shell now works #5480

Closed
wants to merge 1 commit into from

Commits on Jun 27, 2018

  1. Windows,examples: //examples/shell now works

    The targets in //examples/shell:* now use the Bash
    runfiles library in
    @bazel_tools//tools/bash/runfiles and work on
    Windows.
    
    Also undef the RUNFILES_* envvars in
    bazel_example_test::test_shell (which builds the
    shell example project) so that the runfiles
    library discovers its own runfiles instead of
    trying (and failing) to use the enclosing test's
    runfiles (which it shouldn't use, because the test
    executes "bazel run //examples/shell:bin" so that
    target's runfiles are independent of the enclosing
    test's runfiles).
    
    Fixes bazelbuild#3839
    
    Change-Id: I44f9bf9b11f7fac0e1c0995a44c2336846dc2bc8
    laszlocsomor committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    c8a9060 View commit details
    Browse the repository at this point in the history