[singlejar] Remove unused port.cc and actually test desugar_checking_test #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongjiecomputer
changed the title
|
/cc @laszlocsomor |
|
Sorry for the long delay in review. We're in NYC this week for BazelCon. |
laszlocsomor
reviewed
Oct 9, 2018
| @@ -100,7 +99,7 @@ cc_test( | |||
| cc_test( | |||
| name = "desugar_checking_test", | |||
| srcs = [ | |||
| "combiners_test.cc", | |||
| "desugar_checking_test.cc", | |||
There was a problem hiding this comment.
Hm, was desugar_checking_test never actually executing?
There was a problem hiding this comment.
I think it never actually executed. See the commit that introduced desugar_checking library: 5f91119
laszlocsomor
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2241