Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add %virtual_includes% includes substitution #6343

Closed
wants to merge 1 commit into from

Commits on Oct 10, 2018

  1. add %virtual_includes% includes substitution

    Summary:
    use of include_prefix prevents the facility of `includes` from supplying
    the virtual_includes prefix without a substitution pattern. The
    system_include_paths configuration list will contain, for each member of
    `includes`, the _virtual_includes root in place of the string
    `%virtual_includes%`.
    
    Fixes T161160
    
    Test Plan:
    Tested in conjuction with uwebsockets artifactory package
    integration into the AV workspace
    
    Reviewers: #bazel, elischleifer, cmoore
    
    Reviewed By: #bazel, cmoore
    
    Maniphest Tasks: T161160
    
    Differential Revision: https://code.int.uberatc.com/D71932
    
    Conflicts:
    	src/main/java/com/google/devtools/build/lib/rules/cpp/CcCommon.java
    George Gensure committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c244a89 View commit details
    Browse the repository at this point in the history