Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[singlejar] Enable native singlejar on Windows #6608

Closed
wants to merge 2 commits into from
Closed

[singlejar] Enable native singlejar on Windows #6608

wants to merge 2 commits into from

Conversation

rongjiecomputer
Copy link
Contributor

@rongjiecomputer rongjiecomputer commented Nov 6, 2018 •
edited
Loading

See #2241

@rongjiecomputer
Copy link
Contributor Author

@meteorcloudy @laszlocsomor All tests pass \o/

@rongjiecomputer rongjiecomputer changed the title WIP [singlejar] Enable native singlejar on Windows [singlejar] Enable native singlejar on Windows Nov 6, 2018
@meteorcloudy
Copy link
Member

Amazing!

@bazel-io bazel-io closed this in c557399 Nov 6, 2018
@rongjiecomputer rongjiecomputer deleted the singlejar branch November 6, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@jin jin Awaiting requested review from jin

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rongjiecomputer @meteorcloudy @googlebot