Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cc_toolchain targets for the new entries in the default #6663

Closed
wants to merge 2 commits into from
Closed

Add cc_toolchain targets for the new entries in the default #6663

wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Nov 12, 2018

cc_toolchain_suite.

Fixes #6662.

@katre katre requested a review from lberki November 12, 2018 19:38
@katre
Copy link
Member Author

katre commented Nov 12, 2018

This fixes the immediate issue, but since I don't understand why the code is in the current state I don't know if it's the right fix.

@lberki lberki requested review from scentini and removed request for lberki November 13, 2018 10:03
@lberki
Copy link
Contributor

lberki commented Nov 13, 2018

I'll let @scentini judge -- I think this is simply because there is a discrepancy between the labels in the toolchains attribute of default-toolchain and the actual names of the cc_toolchain rules by mistake and thus the right answer is to rename them and not to add a new one.

@scentini
Copy link
Contributor

Yes, this is a discrepancy between the default-toolchain values and the actual cc_toolchain names, introduced in c3fb1db. Reverting the changes made to default-toolchain should do.

@katre
Copy link
Member Author

katre commented Nov 13, 2018

I will update this PR and send it shortly.

@katre
Copy link
Member Author

katre commented Nov 13, 2018

Updated, @scentini please take a look.

scentini
scentini approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in f7e5aef Nov 13, 2018
katre added a commit that referenced this pull request Nov 13, 2018
@katre
Add cc_toolchain targets for the new entries in the default cc_toolch…
94d51fc 
…ain_suite.

Fixes #6662.
Closes #6663.

PiperOrigin-RevId: 221271701
katre added a commit that referenced this pull request Nov 14, 2018
@katre
Add cc_toolchain targets for the new entries in the default cc_toolch…
7c31965 
…ain_suite.

Fixes #6662.
Closes #6663.

PiperOrigin-RevId: 221271701
dslomov pushed a commit that referenced this pull request Nov 26, 2018
@katre @dslomov
Add cc_toolchain targets for the new entries in the default cc_toolch…
9dd0218 
…ain_suite.

Fixes #6662.
Closes #6663.

PiperOrigin-RevId: 221271701
dslomov pushed a commit that referenced this pull request Nov 28, 2018
@katre @dslomov
Add cc_toolchain targets for the new entries in the default cc_toolch…
db46207 
…ain_suite.

Fixes #6662.
Closes #6663.

PiperOrigin-RevId: 221271701
@katre katre deleted the i6662-local-compiler-k8 branch December 11, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scentini scentini scentini approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katre @lberki @scentini @googlebot