Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for the modules used from the JDK. #6846

Closed
wants to merge 2 commits into from

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Dec 5, 2018

It's critical for Bazel's binary size that we don't increase the list of
modules.
We will also use the same list in a later commit build a reduced JDK.

@buchgr
Copy link
Contributor

buchgr commented Dec 5, 2018

Does the test fail if you remove one of the modules? 😛

":jdeps_modules.golden",
":jdeps_class_blacklist.txt",
":test-deps",
"//src:embedded_jdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we minimize the jdk it will not contain a jdeps tool?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency here will change (probably just the name). So this test will depend on the allmodules JDK.

@meisterT
Copy link
Member Author

meisterT commented Dec 5, 2018

Does the test fail if you remove one of the modules?

Yes, I described what to do in which failure case in the header of the test.

It's critical for Bazel's binary size that we don't increase the list of
modules.
We will also use the same list in a later commit build a reduced JDK.
@meisterT
Copy link
Member Author

meisterT commented Dec 5, 2018

Passes the test on Mac as well now.

@bazel-io bazel-io closed this in deac5be Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants