CROSSTOOL docs: fix formatting errors #6974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9b7e8561189124dbcb31aea4333bda4bf3f90681
laszlocsomor
requested review from
aehlig and
hlopko
and removed request for
aehlig
- Use "pre"-tag to format "Feature relationships" table, "Constraints" column - Add an "Action" column for CROSSTOOL build variables' actions. Change-Id: Ifbc296f713b5cc69a5b1836aaf9bffd8f9990a03
Change-Id: I7704bbb9b662ec3e25866abc71b7814074128ed3
|
Looks fantastic, thank you so much! Only nits for consistency. LGTM! |
|
Thank you for the swift review! I see no comments though, did you intend to send none? |
hlopko
approved these changes
Dec 20, 2018
|
Hups :) |
Change-Id: Idd8ad88f3ef8d09ac7901256aa66edc41fa62e68
|
Done. I also removed the line-ending "," in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.