Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[singlejar] Fix Windows long path issue #6992

Closed
wants to merge 9 commits into from
Closed

[singlejar] Fix Windows long path issue #6992

wants to merge 9 commits into from

Conversation

rongjiecomputer
Copy link
Contributor

@rongjiecomputer rongjiecomputer commented Dec 22, 2018 •
edited
Loading

Fix #6990

Drive-by:

  • Add newline for diag_* macros. Singlejar error log should be easier to read now.
  • Resolve a TODO for test_util.
  • Remove int fd() for InputJar and MappedFile. source.bazel.build shows that no one is using them and the removal simplifies the implementation of MappedFile on Windows.

@rongjiecomputer rongjiecomputer changed the title [singlejar] Fix Windows long path issue in MappedFile [singlejar] Fix Windows long path issue Dec 22, 2018
@rongjiecomputer
Copy link
Contributor Author

@laszlocsomor PTAL

@irengrig irengrig added area-Windows Windows-specific issues and feature requests untriaged labels Dec 23, 2018
laszlocsomor
laszlocsomor suggested changes Jan 2, 2019
View reviewed changes
src/tools/singlejar/input_jar.h Outdated Show resolved Hide resolved
laszlocsomor
laszlocsomor approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@laszlocsomor laszlocsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Jan 2, 2019 •
edited
Loading

Unfortunately I cannot submit this due to #7026. @philwo is working on a workaround.

@bazel-io bazel-io closed this in 0a5ea61 Jan 3, 2019
@rongjiecomputer rongjiecomputer deleted the long_path branch January 3, 2019 23:51
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor approved these changes

Assignees

@laszlocsomor laszlocsomor

Labels
area-Windows Windows-specific issues and feature requests cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mobile-install on Windows crashes on singlejar building the stub application's deploy jar
5 participants
@rongjiecomputer @laszlocsomor @philwo @googlebot @irengrig