Windows, launcher: add unit test for flag escaping #7402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meteorcloudy : please note that this PR contains two commits. You should only review the second one, i.e. 915111c . |
Add a unit test to assert that: - WindowsEscapeArg escapes flags as expected - When we pass a WindowsEscapeArg-escaped flag to CreateProcessW, the subprocess receives the original flag. This is a follow-up to bazelbuild#7395 Next I'll fix WindowsEscapeArg to correctly escape arguments. See bazelbuild#7072
laszlocsomor
force-pushed
the
gh-7072-b
branch
from
6cd6294
to
3525dd0
Compare
meteorcloudy
approved these changes
Feb 13, 2019
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this pull request
Feb 13, 2019
Add a correct implementation of WindowsEscapeArg. This is a follow-up to bazelbuild#7402 Next steps: - update Bazel to separate jvm_flags that are embedded in the native lauancher by some other character than space, so that arguments with spaces can be embedded - replace the current WindowsEscapeArg implementation in the launcher with the new, correct one See bazelbuild#7072
bazel-io
pushed a commit
that referenced
this pull request
Feb 13, 2019
Add a correct implementation of WindowsEscapeArg. This is a follow-up to #7402 Next steps: - update Bazel to separate jvm_flags that are embedded in the native lauancher by some other character than space, so that arguments with spaces can be embedded - replace the current WindowsEscapeArg implementation in the launcher with the new, correct one See #7072 Closes #7411. PiperOrigin-RevId: 233733871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test to assert that:
CreateProcessW, the subprocess receives the
original flag.
This is a follow-up to #7395
Next I'll fix WindowsEscapeArg to correctly escape
arguments.
See #7072