Ignore SIGABRT in test setup script #7441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIGABRT is expected when a subprocess ends, and is not indicative of a failure. So, when trapping on signals to detect issues, do not trap on this signal. This has become important with Bash 5, as it has begun propagating this signal up to this level.
laurentlb
pushed a commit
that referenced
this pull request
Feb 22, 2019
SIGCHLD is expected when a subprocess ends, and is not indicative of a failure. So, when trapping on signals to detect issues, do not trap on this signal. This has become important with Bash 5, as it has begun propagating this signal up to this level. Closes #7461. Closes #7441. Progress on #7410 when XML splitting is disabled. PiperOrigin-RevId: 234568715
laurentlb
pushed a commit
that referenced
this pull request
Feb 28, 2019
SIGCHLD is expected when a subprocess ends, and is not indicative of a failure. So, when trapping on signals to detect issues, do not trap on this signal. This has become important with Bash 5, as it has begun propagating this signal up to this level. Closes #7461. Closes #7441. Progress on #7410 when XML splitting is disabled. PiperOrigin-RevId: 234568715
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
SIGCHLD is expected when a subprocess ends, and is not indicative of a failure. So, when trapping on signals to detect issues, do not trap on this signal. This has become important with Bash 5, as it has begun propagating this signal up to this level. Closes #7461. Closes #7441. Progress on #7410 when XML splitting is disabled. PiperOrigin-RevId: 234568715
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
SIGCHLD is expected when a subprocess ends, and is not indicative of a failure. So, when trapping on signals to detect issues, do not trap on this signal. This has become important with Bash 5, as it has begun propagating this signal up to this level. Closes #7461. Closes #7441. Progress on #7410 when XML splitting is disabled. PiperOrigin-RevId: 234568715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGABRT is expected when a subprocess ends, and is not indicative of a
failure. So, when trapping on signals to detect issues, do not trap on
this signal.
This has become important with Bash 5, as it has begun propagating this
signal up to this level.
Fixes #7410