Windows, testing: only look up shell if needed #8161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocsomor
force-pushed
the
test-without-bash
branch
from
36c3a0e
to
9181016
Compare
laszlocsomor
changed the title
TestActionBuilder now only looks up the shell (via ShToolchain.getPathOrError) when the shell is required. Now, when using the Windows-native test wrapper with --shell_toolchain="" (and without a shell-command-looking --run_under argument) the TestActionBuilder won't depend on Bash. Related: bazelbuild#4319
laszlocsomor
force-pushed
the
test-without-bash
branch
from
9181016
to
63c3343
Compare
laszlocsomor
changed the title
ulfjack
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestActionBuilder now only looks up the shell (via
ShToolchain.getPathOrError) when the shell is
required.
Now, when using the Windows-native test wrapper
with --shell_toolchain="" (and without a
shell-command-looking --run_under argument) the
TestActionBuilder won't depend on Bash.
Related: #4319