Windows, docs: tips and tricks to write rules #8420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bazelbuild#3889 Change-Id: Id768d8bd0cb996af566cdda518772ea329e5c6b2
Change-Id: I45d891af48ebe87e3348abe9bb63d0a6e02e0aae
laurentlb
reviewed
May 21, 2019
Change-Id: I95db0a81f04e5478749ecad47ee6e1e6513c2341
|
PTAL |
Change-Id: I59c7952582decee585bbb23f7e8dc6d88e21aa73
laurentlb
approved these changes
May 22, 2019
|
This will be amazingly helpful! Thanks for writing this! |
|
Thank you! And for the reviews too :) |
meteorcloudy
approved these changes
May 22, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
See bazelbuild#3889 Change-Id: Id768d8bd0cb996af566cdda518772ea329e5c6b2 Closes bazelbuild#8420. Change-Id: I59c7952582decee585bbb23f7e8dc6d88e21aa73 PiperOrigin-RevId: 249431252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3889
Change-Id: Id768d8bd0cb996af566cdda518772ea329e5c6b2