Add --incompatible_use_platforms_repo_for_constraints #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details.
katre
reviewed
Jun 13, 2019
There was a problem hiding this comment.
Are you handling all uses of @bazel_tools//platforms in this change, or in a series?
Off the top of my head:
- cc_configure-generated toolchains
- Possibly Java toolchains in tools/jdk
- LocalConfigPlatformFunction: https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/repository/LocalConfigPlatformFunction.java;l=81?q=LocalConfigPlatform?
|
Yeah I will eventually (was running presubmits to see what will break, then got derailed by the rollback of @bazel_tools and @platforms cl :) I'll ping you when this is ready to be reviewed (assuming you have no objections to the approach in general). |
|
The approach is good, although I'm worried about dependency cycles (alias needs a configuration, but not platforms need the alias, but configurations need a platform...). Passing tests will reassure me greatly. |
* master: (33 commits) Make setAllowResidue and enableParamsFileSupport private. Embed @platforms into the Bazel binary Add flag to enable the JSON profile by default. Deflake test_build_fail_terse_summary. Add WalkableGraph#getValueAndRdeps that allows fetching both the rdeps and value in a single call Add new flag to Stardoc and allows Stardoc to output raw serialized proto. Require the "command" param of run_shell is a string Delete some messages formerly used for serialization code which no longer exists Only eagerly read dependency files when Bazel-side Java classpath reduction is used. Otherwise, this is just wasted effort. Rename SkylarkMutable to StarlarkMutable Fix import_deps_checker to use the correct OptionsParser factory method. Don't capture a member in the lambda created in JavaHeaderCompileActionBuilder. Otherwise, that capture keeps the entire Builder instance alive, consuming memory. Refactor the server startup codepath Clean up usages of setAllowResidue and enableParamsFileSupport to pass values into the factory method. Don't allow ctx.split_attr to access starlark transitions attributes. Include intermediate output key as a typed parameter for ParallelVisitor. Remove SkylarkAttributeAspect and friends Update android_tools and create version 0.6. Remove the flag `incompatible_disallow_native_in_build_file` Remove the flag `incompatible_no_kwargs_in_build_files`. ...
|
Ptal! Looks green on the CI :) |
|
Actually let me import it and see what happens internally. |
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details. Closes bazelbuild#8625. PiperOrigin-RevId: 253242115
bazel-io
pushed a commit
that referenced
this pull request
Jun 21, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: #8622 Tracking issue: #6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See #8622 for details. Closes #8625. This is encore of 332379a. Previous implementation failed with dependency cycle with the configuration. In this attempt I don't use selects, but I've put the incompatible flag checking logic directly into the alias rule. Not nice, but get's thing done. RELNOTES: PiperOrigin-RevId: 254357477
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details. Closes bazelbuild#8625. PiperOrigin-RevId: 253242115
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details. Closes bazelbuild#8625. This is encore of bazelbuild@332379a. Previous implementation failed with dependency cycle with the configuration. In this attempt I don't use selects, but I've put the incompatible flag checking logic directly into the alias rule. Not nice, but get's thing done. RELNOTES: PiperOrigin-RevId: 254357477
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details. Closes bazelbuild#8625. PiperOrigin-RevId: 253242115
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
This change adds an incompatible flag to disable constrains bundled with Bazel in @bazel_tools. Incompatible change issue: bazelbuild#8622 Tracking issue: bazelbuild#6516 RELNOTES: Incompatible change `--incompatible_use_platforms_repo_for_constraints` has been added. See bazelbuild#8622 for details. Closes bazelbuild#8625. This is encore of bazelbuild@332379a. Previous implementation failed with dependency cycle with the configuration. In this attempt I don't use selects, but I've put the incompatible flag checking logic directly into the alias rule. Not nice, but get's thing done. RELNOTES: PiperOrigin-RevId: 254357477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an incompatible flag to disable constrains bundled with Bazel
in @bazel_tools.
Incompatible change issue:
#8622
Tracking issue:
#6516
RELNOTES: Incompatible change
--incompatible_use_platforms_repo_for_constraintshas been added. See #8622 for details.