Renovated all Rust examples #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
marvin-hansen
requested review from
ahumesky,
jin,
gregestren and
Wyverald
as code owners
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
|
Update: Repro: https://github.com/marvin-hansen/bazel_8_rust The underlying issue is possibly related to: bazelbuild/rules_rust#2801 |
|
@illicitonion mind taking a look? Also just be careful, the diff is gi-gan-tic -- it froze my Chrome tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to some failing CI tests against Bazel 8, I checked all Rust examples and renovated all of them.
Most examples are good with Bazel 8 and just got a makeover, that means:
However, HEAD somehow breaks some internals of crate universe, which affects examples 4, 5, and 7.
I see the same issue as in the failing CI build, so I am working on a repro and fill an issue with rules_rust.
Now, the issue may take a bit of time to investigate and resolve, so in the meantime, please review this PR.
Build is green, so at least that's out of the way.