-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(rebase) Support embedded go_proto_library #6030
(rebase) Support embedded go_proto_library #6030
Conversation
0c5166d
to
6a9ba65
Compare
@mai93 @tpasternak could I have a review on this? I'll give co-author credit to @tingilee on the merge commit, but they don't have their branch open to pushes. |
756316c
to
37d8793
Compare
I'll solve the WORKSPACE conflicts, it just never ends so I'll wait for a review before solving them again. |
aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/GoTest.java
Outdated
Show resolved
Hide resolved
I think since bazel-gazelle is part of bazelbuild it should be fine. |
It's also google.golang.org/grpc |
cc @mai93 |
It's not concerning. It's just a new dependency so I always have concerns, sorry |
Ok, so if there are no issues with dependencies (cc @mai93), then it LGTM. Btw is |
bd6a835
to
60c5ee5
Compare
5e770b3
to
e9dd859
Compare
I've addressed the comments (and added a comment on why we import |
This is just a rebase and cleanup of this PR from @tingilee : #5567. The feature work is entirely theirs.
fixes #5538, #3328