Set runfiles vars to absolute paths when debugging Go tests #6883
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: GoLand
Otherwise they will be incorrectly interpreted relative to the modified working directory.
3 tasks
tpasternak
approved these changes
Oct 11, 2024
github-actions
bot
removed
the
awaiting-review
mai93
pushed a commit
that referenced
this pull request
Oct 21, 2024
Otherwise they will be incorrectly interpreted relative to the modified working directory. (cherry picked from commit 017e063)
mai93
pushed a commit
that referenced
this pull request
Oct 21, 2024
Otherwise they will be incorrectly interpreted relative to the modified working directory. (cherry picked from commit 017e063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #6748 (comment)
Description of this change
Ensure that runfiles vars are not incorrectly interpreted relative to the modified working directory (used as of #6748) by making their paths absolute. This matches the logic in Bazel's test setup script.