Use execroot for compiler working directory #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
custom-toolchain-fix
branch
from
b7cecf1
to
d163a28
Compare
github-actions
bot
added
product: CLion
ujohnny
requested changes
Oct 21, 2024
| @@ -0,0 +1,21 @@ | |||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | |||
There was a problem hiding this comment.
let's move to bzlmod for this test because we use bazel 7+ anyway
There was a problem hiding this comment.
I migrated the test, but I cannot delete the WORKSPACE file because rules_bazel_integration_test requires a WORKSPACE file.
LeFrosch
force-pushed
the
custom-toolchain-fix
branch
from
b4146dc
to
1e0210a
Compare
ujohnny
approved these changes
Oct 22, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the working directory of the compiler to the current execroot. Also adds an integration test for the custom llvm toolchain.