Issue 3555 illegal character trying to debug gotest #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't show up when run. (bazelbuild#3555)
…ying-to-debug-gotest
iliakondratev
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: GoLand
tpasternak
approved these changes
Oct 30, 2024
github-actions
bot
removed
the
awaiting-review
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #3555
Description of this change
This pull request addresses two issues that currently prevent debugging of both test and binary targets in GoLand with the Bazel plugin on Windows.
Platform-specific shell script parsing: The Bazel-generated execution shell script was not correctly parsed on Windows due to platform-specific differences.
Fix: Updated the regexes for compatibility with Windows.
Handling of
RUNFILES_MANIFEST_ONLYflag: On Windows, Bazel setsRUNFILES_MANIFEST_ONLYflag to use path mapping from a manifest file instead of symlinks, which the plugin does not support.Fix: Added logic to check for
RUNFILES_MANIFEST_ONLYand display a popup asking to allow symlink support in.bazelrcto align with Bazel’s Windows setup.