Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: java_tools v11.4 #51

Closed
hvadehra opened this issue Sep 27, 2021 · 10 comments
Closed

Release: java_tools v11.4 #51

hvadehra opened this issue Sep 27, 2021 · 10 comments
Labels

Comments

@hvadehra
Copy link
Member

No description provided.

@hvadehra
Copy link
Member Author

@hvadehra
Copy link
Member Author

Commit hash: a899bc7c87ffa3ccfcd5921fc4ac81cd69793318

@hvadehra
Copy link
Member Author

$ src/create_java_tools_release.sh --commit_hash a899bc7c87ffa3ccfcd5921fc4ac81cd69793318 --java_tools_version 11.4 --rc 1 --release false

release_candidates/java/v11.4/java_tools_linux-v11.4-rc1.zip e27802e9327002e9a3e3fcb9672f9862eac4698b7d786d3fd52111d9debba343
release_candidates/java/v11.4/java_tools_windows-v11.4-rc1.zip 632eb9a83b61f4a897dafd961b3a988188e1e86cc6161f4f51e22c6f71d205ad
release_candidates/java/v11.4/java_tools_darwin-v11.4-rc1.zip fc0df786c3487874e0bc0ba86f7ca40c939eaddfebac35cb2426969e1bb133cf
release_candidates/java/v11.4/java_tools-v11.4-rc1.zip fbbac0fe9332fa863497e65cfa9010816cfcd981dee9cfebb048c990e1d6020d

@hvadehra
Copy link
Member Author

ERROR: ..../src/main/java/com/google/devtools/build/lib/vfs/BUILD:42:13: Building src/main/java/com/google/devtools/build/lib/vfs/libvfs.jar (27 source files) and running annotation processors (AutoCodecProcessor, OptionProcessor) failed: (Exit 1): java failed: error executing command external/remotejdk11_linux/bin/java -XX:-CompactStrings '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED' '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED' ... (remaining 17 arguments skipped)
src/main/java/com/google/devtools/build/lib/vfs/DigestHashFunction.java:190: error: [ReturnValueIgnored] Return value of 'clone' must be used
      toCheck.clone();

CI is breaking, probably due to new error prone checks: google/error-prone@e9aa66a

bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Sep 27, 2021
@cushon
Copy link

cushon commented Sep 27, 2021

@hvadehra can you try again after bazelbuild/bazel@cf57345 ? That should disable the breaking change to ReturnValueIgnored

@hvadehra
Copy link
Member Author

@hvadehra
Copy link
Member Author

commit hash: cf573455e8205a2b79629df1b5eb4e3b9efabec1

$ src/create_java_tools_release.sh --commit_hash cf573455e8205a2b79629df1b5eb4e3b9efabec1 --java_tools_version 11.4 --rc 2 --release false

release_candidates/java/v11.4/java_tools_linux-v11.4-rc2.zip 328305fafcbe8499af62aaaa85c95dd33569187c65b5830b4a688c87de1ed2d7
release_candidates/java/v11.4/java_tools_windows-v11.4-rc2.zip 626d58ace1d461a861f7c5cbbbb0751c4753a734b6987d0fd4a6428cf48155e2
release_candidates/java/v11.4/java_tools_darwin-v11.4-rc2.zip 157f3af23b0cc4b529cde51bdd829557d06d1b2958ec4d3bbe2520887a5b583c
release_candidates/java/v11.4/java_tools-v11.4-rc2.zip 2419d577ea69096bb754504aa4c7ccedb49d7fffdec6102fbfc6f0a52f1dd9a9

@hvadehra
Copy link
Member Author

@hvadehra
Copy link
Member Author

$ src/create_java_tools_release.sh --commit_hash cf573455e8205a2b79629df1b5eb4e3b9efabec1 --java_tools_version 11.4 --rc 2 --release true

releases/java/v11.4/java_tools_linux-v11.4.zip 328305fafcbe8499af62aaaa85c95dd33569187c65b5830b4a688c87de1ed2d7
releases/java/v11.4/java_tools_windows-v11.4.zip 626d58ace1d461a861f7c5cbbbb0751c4753a734b6987d0fd4a6428cf48155e2
releases/java/v11.4/java_tools_darwin-v11.4.zip 157f3af23b0cc4b529cde51bdd829557d06d1b2958ec4d3bbe2520887a5b583c
releases/java/v11.4/java_tools-v11.4.zip 2419d577ea69096bb754504aa4c7ccedb49d7fffdec6102fbfc6f0a52f1dd9a9

@hvadehra
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants