Fix app intents with Xcode 15.3+ #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
referenced
this pull request
Feb 29, 2024
…pects all values to be statically allocated and resolved at compile time. This pulls all of the module names found from SwiftInfo when gathering the swiftconstfiles. This appears to work in the test targets set up, which do lean on the multiple module strategy. PiperOrigin-RevId: 589938532
keith
referenced
this pull request
Feb 29, 2024
…e's app intents metadata processor tool allows for. PiperOrigin-RevId: 590322476
keith
referenced
this pull request
Feb 29, 2024
… Xcode 15.3 builds, based on the version string reported from the XcodeVersionConfig provider. PiperOrigin-RevId: 601786735
BalestraPatrick
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
May 17, 2024
…e extraction. (#1170) This cherry-picks support for producing const values produced via the compiler flags `-emit-const-values-path` and `-const-gather-protocols-file`. rules_apple will start using this feature in bazelbuild/rules_apple#2418. --------- Co-authored-by: Tony Allevato <allevato@google.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
|
Has the time come at last? |
|
Yes, we just need a new |
BalestraPatrick
force-pushed
the
ks/app-intents-fixes
branch
2 times, most recently
from
878e81b
to
03a242c
Compare
BalestraPatrick
added a commit
that referenced
this pull request
Jun 3, 2024
…2465) This was recently enabled in rules_swift (with bazelbuild/rules_swift#1191) and it seems to be required in the next `rules_swift` bump. I saw the failure initially when testing a rules_swift bump in #2418 which was [failing](https://buildkite.com/bazel/rules-apple-darwin/builds/9191#018fdd69-abfb-451a-a454-4b0771e26b77) with the following error only in the Bazel 6.x configuration as expected (since it's enabled by default on Bazel 7): ``` Error: No attribute 'aspect_hints' in attr. Make sure you declared a rule attribute with this name. ```
BalestraPatrick
force-pushed
the
ks/app-intents-fixes
branch
2 times, most recently
from
03a242c
to
ff75463
Compare
BalestraPatrick
force-pushed
the
ks/app-intents-fixes
branch
from
ff75463
to
2d8c216
Compare
|
@BalestraPatrick can you update this to point to the rules_swift 2.0.0-rc1 release? I'm going to create a release without this change, which is compatible but doesn't require rules_swift 2.0, and then once that is out we can start depending on it in order to merge this? |
BalestraPatrick
force-pushed
the
ks/app-intents-fixes
branch
2 times, most recently
from
f681f60
to
345bb3e
Compare
|
@brentleyjones Updated now. I also pushed a possible fix for one breaking change ( |
|
@BalestraPatrick looks like this is validated on CI now #2488 |
|
I left a comment here: #2488 (comment) But it looks on rules_apple side we also need to fix the docc rules (#2487) in order to bump to rules_swift 2.0.0 which is required for this PR to be merged. |
brentleyjones
pushed a commit
that referenced
this pull request
Jul 9, 2024
…r logic. PiperOrigin-RevId: 589151949 (cherry picked from commit 41d5bb7)
…pects all values to be statically allocated and resolved at compile time. This pulls all of the module names found from SwiftInfo when gathering the swiftconstfiles. This appears to work in the test targets set up, which do lean on the multiple module strategy. PiperOrigin-RevId: 589938532 (cherry picked from commit 5668eb4)
…e's app intents metadata processor tool allows for. PiperOrigin-RevId: 590322476 (cherry picked from commit 21b435b)
… Xcode 15.3 builds, based on the version string reported from the XcodeVersionConfig provider. PiperOrigin-RevId: 601786735 (cherry picked from commit ea240b8)
luispadron
force-pushed
the
ks/app-intents-fixes
branch
from
f9bcd89
to
2221ba3
Compare
luispadron
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Jul 9, 2024
|
The failures are due to DocC rules needing to be updated for rules_swift 2.0, thats being done over in: #2487 The intents tests are passing though via: |
This was referenced Jul 9, 2024
brentleyjones
pushed a commit
that referenced
this pull request
Jul 10, 2024
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
Updates the **rules_swift** dependency to 2.0.0. This unblocks the new rules/aspects in other planned PRs ## Tasks - [x] Wait for a final 2.0.0 release ## Follow up tasks - Merge bazelbuild#2418 - Merge bazelbuild#2487
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
Depends on bazelbuild/rules_swift#1170 --------- Co-authored-by: Nicholas Levin <nglevin@google.com> Co-authored-by: Patrick Balestra <me@patrickbalestra.com> Co-authored-by: Luis Padron <lpadron@squareup.com>
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
Updating to rules_swift 2.x will be required by: - bazelbuild#2418 - bazelbuild#2487
congt
added a commit
to bazel-ios/rules_swift
that referenced
this pull request
Nov 14, 2024
It cherry-picks the rule change of bazelbuild#1170 on top of rules_swift v1.6.0. It's quired to fix app intent on Xcode 15.3+. See bazelbuild/rules_apple#2418.
congt
added a commit
to bazel-ios/rules_apple
that referenced
this pull request
Nov 14, 2024
App intent is broken on Xcode 15.3+. Here is the fix bazelbuild#2418. However, we cannot bump rules_apple yet because of the breaking change of bazelbuild#2476.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bazelbuild/rules_swift#1170