Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate tools for cc_tool_map #256

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Deduplicate tools for cc_tool_map #256

merged 1 commit into from
Oct 30, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 15, 2024

Fixes #235

@fmeum fmeum force-pushed the 235-better-tool-map branch 2 times, most recently from 6f8700a to 06a5e1c Compare October 15, 2024 12:24
@fmeum fmeum marked this pull request as ready for review October 15, 2024 12:24
@fmeum fmeum force-pushed the 235-better-tool-map branch from 06a5e1c to 7189171 Compare October 15, 2024 12:28
@fmeum fmeum force-pushed the 235-better-tool-map branch from 7189171 to 3d51aaa Compare October 15, 2024 12:30
@comius comius requested review from armandomontanez and removed request for oquenchil October 25, 2024 06:22
armandomontanez
armandomontanez approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@armandomontanez armandomontanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is cleaner than the solution I was considering. :)

@fmeum fmeum closed this Oct 30, 2024
@copybara-service copybara-service bot merged commit a5827bf into bazelbuild:main Oct 30, 2024
2 of 3 checks passed
@fmeum fmeum deleted the 235-better-tool-map branch November 11, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandomontanez armandomontanez armandomontanez approved these changes

@c-mita c-mita Awaiting requested review from c-mita c-mita is a code owner

@comius comius Awaiting requested review from comius comius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot list the same tool twice in a cc_tool_map
2 participants
@fmeum @armandomontanez