Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

use python_version = PY2 for par_binary and py_binary targets #787

Closed
wants to merge 3 commits into from

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Apr 5, 2019

Addresses bazelbuild/rules_k8s#305
Sending PR to kick off presubmits and also check if rules_k8s will be fixed by changing pin to this commit + adding some more python_version = PY2 there.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlopezgi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor Author

nlopezgi commented Apr 5, 2019

This PR still needs a bit more documentation and organizing stuff. Please hold off reviewing.

@nlopezgi
Copy link
Contributor Author

nlopezgi commented Apr 5, 2019

I also need to change how the default_py_runtime is generated, right now it has a hardcoded path that will not work with travisCI setup. Will need to create a repo rule that uses which to find location of py2 and py3 binaries.

@nlopezgi
Copy link
Contributor Author

nlopezgi commented May 8, 2019

closing in favor of #826

@nlopezgi nlopezgi closed this May 8, 2019
@nlopezgi nlopezgi deleted the usePyRuntime branch June 27, 2019 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants