This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: inline some rules_docker 'skylib' helpers #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: I think it might be better to introduce a dep on aspect_bazel_lib instead, which is a very-well maintained utility library that's a superset of bazel_skylib, and evidently rules_docker wished for such a thing as well since it had this folder. Baby steps towards bazelbuild#723 I'd like to start small and gauge interest from rules_k8s maintainers before spending too much time here.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexeagle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I think it might be better to introduce a dep on aspect_bazel_lib instead, which is a very-well maintained utility library that's a superset of bazel_skylib, and evidently rules_docker wished for such a thing as well since it had this folder.
Baby steps towards #723
I'd like to start small and gauge interest from rules_k8s maintainers before spending too much time here.