Version kotlinc plugins by major version to handle API changes. #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows reuse when defining kotlinc versions. Supporting multiple plugin apis will require supporting multiple kotlincs.
Managing multiple kotlinc version increases toil. To simplify things, introduce a centralized list of the support versions of kotlinc. Success for this is predicated on the plugin api remaining stable on point releases, which is anecdotally true.
This provides a separate plugin for each major kotlinc release. Still requires wiring into the toolchain system (follow up PR), but simplifies using older versions of kotlin with less effort.
restingbull
changed the title
Current stardoc cannot seem to handle dynamic key in dictionary comprehensions. The simple solution is to separate the KOTLINC_INDEX from the compiler repository definition. Has the added benefit of keeping development logic from production logic.
This was apparently skipped on previous passes.
Bencodes
reviewed
Aug 14, 2023
| release = "1.6.21", | ||
| sha256 = "632166fed89f3f430482f5aa07f2e20b923b72ef688c8f5a7df3aa1502c6d8ba", | ||
| ), | ||
| ], | ||
| KSP_CURRENT_COMPILER_PLUGIN_RELEASE = version( |
There was a problem hiding this comment.
KSP also needs to be versioned to the Kotlin compiler.
There was a problem hiding this comment.
Well, this is going to be fun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of two.
@nkoroste discovered we had been breaking backwards compatibility by updating the plugins as the compiler plugin api changes.
These separates and compiles each major version of the compiler plugins. The follow up pr will choose the correct plugin for the toolchain -- separating the efforts made sense form a complexity and limiting the scope of the PR point of view.