Add BCR configurations for publishing releases to the central registry #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber and
restingbull
as code owners
|
Added code owners fixes to bring it inline with the maintainers list. |
restingbull
approved these changes
Oct 12, 2023
Thanks! |
Bencodes
commented
Oct 12, 2023
.bcr/presubmit.yml
Outdated
| platform: ${{ platform }} | ||
| build_flags: | ||
| - "--enable_bzlmod=false" | ||
| build_targets: |
There was a problem hiding this comment.
Worth noting that we don't actually check tests into the release binary of rules_kotlin so there isn't much to run on the Bazel central registry presubmit side.
Bencodes
commented
Oct 12, 2023
.github/workflows/release.yml
Outdated
| tag: ${{ github.ref }} | ||
| overwrite: true | ||
| release: | ||
| uses: bazel-contrib/.github/.github/workflows/release_ruleset.yaml@v4 |
There was a problem hiding this comment.
This changes howe we cut releases in rules_kotlin. The way to create releases is to now push a tag like v4.0.0
Bencodes
commented
Oct 12, 2023
| # This file contains Bazel settings to apply on CI only. | ||
| # It is referenced with a --bazelrc option in the call to bazel in ci.yaml | ||
| common --curses=no | ||
| common --enable_bzlmod |
There was a problem hiding this comment.
This config is only used by bazel-contrib/.github/.github/workflows/release_ruleset.yaml@v4
Bencodes
force-pushed
the
add-bcr-configurations-for-publishing-releases-to-the-central-registry
branch
from
2fb5255
to
8273c69
Compare
|
Tagged a release from this branch to see if everything works bazelbuild/bazel-central-registry#999 |
Remove non-existent users Add Ben and Nick
Bencodes
force-pushed
the
add-bcr-configurations-for-publishing-releases-to-the-central-registry
branch
from
dd7c396
to
8ac8b17
Compare
This was referenced Oct 20, 2023
Bencodes
deleted the
add-bcr-configurations-for-publishing-releases-to-the-central-registry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BCR configurations so that we can start deploying future releases to the Bazel central registry.
This pull request pulls in the
bazel-contribGithub actions for creating Github releases and publishing to the central registry.