Update released_rules_kotlin to 1.9.6 #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
restingbull and
nkoroste
as code owners
|
We may need to actually point this version at something closer to HEAD so we can get more of the Kotlin 2.0 changes. |
jbarr21
reviewed
Sep 12, 2024
| @@ -30,7 +30,6 @@ rules_kotlin_bootstrap_extensions = use_extension( | |||
| ) | |||
There was a problem hiding this comment.
should rules_kotlin also be updated from 1.8.1 to 1.9.6? and also update in MODULE.release.bazel?
There was a problem hiding this comment.
For completeness, yes.
Practically, it doesn't do anything.
restingbull
approved these changes
Sep 12, 2024
restingbull
pushed a commit
that referenced
this pull request
Sep 21, 2024
restingbull
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking the upstream releases of this.