Convert strings to label with the correct repository #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comius
requested review from
cgruber,
timpeut and
restingbull
as code owners
This was referenced Dec 22, 2022
Closed
fmeum
reviewed
Dec 22, 2022
restingbull
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
absolute_targetand useLabelin the top-level bzl scope. This makesLabelcorrectly evaluate to point to the repository where bzl file resides.Bzlmod is more stringent about labels and
absolute_targetimplementation doesn't work with it - the created labels are de-funct.This works towards #660
It's one of the minor issues.