Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut at making a release binary #26

Merged
merged 4 commits into from
Feb 3, 2022
Merged

First cut at making a release binary #26

merged 4 commits into from
Feb 3, 2022

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Jan 24, 2022

This PR adds the framework to make a release binary that should be used by any rule set that just wants to declare a license. As such, the package does not depend on any other rules.

This is the first of several PRs which will bootstrap a steady state.

  • this PR
  • cut a release
  • update rules_pkg to use the release
  • cut a rules_pkg release
  • verify we can depend on each other correctly in this embrace
  • vendor this package to bazelbuild/bazel
  • produce compliance report showing rules_pkg licensing
  • iterate through other repositories.

Copy link
Collaborator

@danielmachlab danielmachlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tony, these changes look good to me.

I tested out the change by pulling the branch and building the new targets. I also took the rules_license-0.0.1.tar.gz produced by bazel build distro:distro and used it in one of my example projects that uses rules_license for licensing. Everything worked as expected.

@aiuto aiuto merged commit 4a20d4e into bazelbuild:main Feb 3, 2022
@aiuto aiuto deleted the pkg branch February 3, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants