Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@bazel/create --typescript gives bad load syntax in 2.0 rc #2033

Closed
alexeagle opened this issue Jul 13, 2020 · 1 comment
Closed

@bazel/create --typescript gives bad load syntax in 2.0 rc #2033

alexeagle opened this issue Jul 13, 2020 · 1 comment
Labels
bug
Milestone
2.0

Comments

@alexeagle
Copy link
Collaborator 

% npx @bazel/create@next --typescript foo
% tail foo/WORKSPACE.bazel
# Setup TypeScript toolchain
load("//packages/typescript:index.bzl", "ts_setup_workspace")
ts_setup_workspace()

//packages/typescript doesn't exist in the distro
@alexeagle alexeagle added this to the 2.0 milestone Jul 13, 2020
@alexeagle
Copy link
Collaborator Author

Actually ts_setup_workspace doesn't even do anything now, so I think we should remove it

alexeagle pushed a commit that referenced this issue Jul 13, 2020
chore: remove ts_setup_workspace
6d3ec33 
This has been a no-op since 1.0 when we vendored requirejs for ts_devserver in
https://github.com/bazelbuild/rules_nodejs/pull/1159/files#diff-fe375cd73fb89504b9b9a9a751518849

We should never add WORKSPACE dependencies so I don't see a value in users carrying this weight.

BREAKING CHANGE: ts_setup_workspace was a no-op and has been removed. Simply remove it from your WORKSPACE file.

Fixes #2033
@alexeagle alexeagle mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@alexeagle