-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builtin): add transitive typings to runfiles provider produced by js_library #2547
fix(builtin): add transitive typings to runfiles provider produced by js_library #2547
Conversation
I'm surprised this is useful, what's the use case? a typescript program deps on a binary and wants to typecheck against some library code contained in that binary? |
Yeah, internally running
|
4fed67f
to
3daba63
Compare
|
…duced by js_library (#2547)" This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
…duced by js_library (#2547)" This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
…duced by js_library (#2547)" (#3189) This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
…duced by js_library (#2547)" (#3189) This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
…duced by js_library (#2547)" (#3189) This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
Add transitive typings to runfiles provider produced by
js_library
. Allows downstream consumers that require the.d.ts
files at runtime (eg typechecking) to access the files via the runfiles tree.