Add @rules_license style license declarations (#508)

* Add @rules_license declarations. This is a little more unwieldy than we would like, in that we hand add them to each BUILD file. This should be enforced with a test, but it should be a non-Bazel test at the source code level.
bazelbuild · Feb 16, 2022 · 3c0b364 · 3c0b364
1 parent a8638d6
commit 3c0b364
Show file tree

Hide file tree

Showing 27 changed files with 80 additions and 9 deletions.
diff --git a/BUILD b/BUILD
@@ -12,16 +12,29 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_license//rules:license.bzl", "license")
+
+package(
+    default_applicable_licenses = [":license"],
+    default_visibility = ["//visibility:public"],
+)
+
+license(
+    name = "license",
+    license_kinds = [
+        "@rules_license//licenses/spdx:Apache-2.0"
+    ],
+    license_text = "LICENSE",
+)
+
 exports_files(
     ["WORKSPACE"],
-    visibility = ["//visibility:public"],
 )
 
 exports_files(
     glob([
         "*.bzl",
     ]),
-    visibility = ["//visibility:public"],
 )
 
 filegroup(

diff --git a/distro/BUILD b/distro/BUILD
@@ -20,9 +20,8 @@ load("@rules_python//python:defs.bzl", "py_test")
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
 
-licenses(["notice"])
-
 package(
+    default_applicable_licenses = ["//:license"],
     default_visibility = ["//visibility:private"],
 )
 

diff --git a/doc_build/BUILD b/doc_build/BUILD
@@ -24,6 +24,8 @@ load("@bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
 load("@rules_python//python:defs.bzl", "py_library")
 load("//:version.bzl", "version")
 
+package(default_applicable_licenses = ["//:license"])
+
 filegroup(
     name = "standard_package",
     srcs = [

diff --git a/pkg/BUILD b/pkg/BUILD
@@ -15,7 +15,7 @@
 # -*- coding: utf-8 -*-
 load("@rules_python//python:defs.bzl", "py_binary", "py_library")
 
-licenses(["notice"])
+package(default_applicable_licenses = ["//:license"])
 
 exports_files(
     glob([

diff --git a/pkg/deps.bzl b/pkg/deps.bzl
@@ -36,6 +36,14 @@ def rules_pkg_dependencies():
         url = "https://github.com/bazelbuild/rules_python/releases/download/0.1.0/rules_python-0.1.0.tar.gz",
         sha256 = "b6d46438523a3ec0f3cead544190ee13223a52f6a6765a29eae7b7cc24cc83a0",
     )
+    maybe(
+        http_archive,
+        name = "rules_license",
+        urls = [
+            "https://mirror.bazel.build/github.com/bazelbuild/rules_license/releases/download/0.0.1/rules_license-0.0.1.tar.gz",
+        ],
+        sha256 = "4865059254da674e3d18ab242e21c17f7e3e8c6b1f1421fffa4c5070f82e98b5",
+    )
 
 
 def rules_pkg_register_toolchains():

diff --git a/pkg/legacy/BUILD b/pkg/legacy/BUILD
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+package(default_applicable_licenses = ["//:license"])
+
 exports_files(["rpm.bzl"])
 
 filegroup(

diff --git a/pkg/legacy/tests/rpm/BUILD b/pkg/legacy/tests/rpm/BUILD
@@ -15,6 +15,8 @@
 
 load("//pkg:rpm.bzl", "pkg_rpm")
 
+package(default_applicable_licenses = ["//:license"])
+
 pkg_rpm(
     name = "test-rpm",
     data = [

diff --git a/pkg/private/BUILD b/pkg/private/BUILD
@@ -18,7 +18,7 @@ All interfaces are subject to change at any time.
 
 load("@rules_python//python:defs.bzl", "py_library")
 
-licenses(["notice"])
+package(default_applicable_licenses = ["//:license"])
 
 filegroup(
     name = "standard_package",

diff --git a/pkg/private/deb/BUILD b/pkg/private/deb/BUILD
@@ -18,6 +18,8 @@ All interfaces are subject to change at any time.
 
 load("@rules_python//python:defs.bzl", "py_library")
 
+package(default_applicable_licenses = ["//:license"])
+
 filegroup(
     name = "standard_package",
     srcs = [

diff --git a/pkg/private/zip/BUILD b/pkg/private/zip/BUILD
@@ -18,7 +18,7 @@ All interfaces are subject to change at any time.
 
 load("@rules_python//python:defs.bzl", "py_library")
 
-licenses(["notice"])
+package(default_applicable_licenses = ["//:license"])
 
 filegroup(
     name = "standard_package",

diff --git a/pkg/releasing/BUILD b/pkg/releasing/BUILD
@@ -1,9 +1,8 @@
 load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_test")
 load("git.bzl", "git_changelog")
 
-licenses(["notice"])
-
 package(
+    default_applicable_licenses = ["//:license"],
     default_visibility = ["//visibility:public"],
 )
 

diff --git a/pkg/rpm/BUILD b/pkg/rpm/BUILD
@@ -14,6 +14,8 @@
 
 load("@rules_python//python:defs.bzl", "py_binary")
 
+package(default_applicable_licenses = ["//:license"])
+
 exports_files(
     glob([
         "*.bzl",

diff --git a/tests/BUILD b/tests/BUILD
@@ -22,6 +22,8 @@ load("//pkg:mappings.bzl", "pkg_attributes", "pkg_mkdirs")
 load("//pkg:tar.bzl", "pkg_tar")
 load("//pkg:zip.bzl", "pkg_zip")
 
+package(default_applicable_licenses = ["//:license"])
+
 licenses(["notice"])
 
 exports_files(glob(["testdata/**"]))

diff --git a/tests/deb/BUILD b/tests/deb/BUILD
@@ -22,6 +22,8 @@ load("//pkg:deb.bzl", "pkg_deb")
 load("//pkg:tar.bzl", "pkg_tar")
 load("//tests:my_package_name.bzl", "my_package_naming")
 
+package(default_applicable_licenses = ["//:license"])
+
 genrule(
     name = "generate_files",
     outs = [

diff --git a/tests/install/BUILD b/tests/install/BUILD
@@ -17,6 +17,8 @@ load("//pkg:install.bzl", "pkg_install")
 load("//pkg:mappings.bzl", "pkg_attributes", "pkg_files", "pkg_mkdirs")
 load("//tests/util:defs.bzl", "fake_artifact")
 
+package(default_applicable_licenses = ["//:license"])
+
 py_test(
     name = "install_test",
     srcs = ["test.py"],

diff --git a/tests/mappings/BUILD b/tests/mappings/BUILD
@@ -30,6 +30,8 @@ load(
 load("//tests/util:defs.bzl", "directory", "write_content_manifest")
 load("@rules_python//python:defs.bzl", "py_test")
 
+package(default_applicable_licenses = ["//:license"])
+
 py_library(
     name = "manifest_test_lib",
     srcs = ["manifest_test_lib.py"],

diff --git a/tests/mappings/filter_directory/BUILD b/tests/mappings/filter_directory/BUILD
@@ -25,6 +25,8 @@ load("//tests/util:defs.bzl", "directory")
 # Base case
 ############################################################################
 
+package(default_applicable_licenses = ["//:license"])
+
 inspect_directory_test(
     name = "base",
     directory = ":test_directory",

diff --git a/tests/rpm/BUILD b/tests/rpm/BUILD
@@ -32,6 +32,8 @@ load("toolchain_tests.bzl", "create_toolchain_analysis_tests")
 # analysis tests
 ############################################################################
 
+package(default_applicable_licenses = ["//:license"])
+
 analysis_tests(name = "analysis_tests")
 
 create_toolchain_analysis_tests()

diff --git a/tests/rpm/source_date_epoch/BUILD b/tests/rpm/source_date_epoch/BUILD
@@ -20,6 +20,8 @@ load("//pkg:rpm.bzl", "pkg_rpm")
 # Test handling the source_date_epoch attribute
 ############################################################################
 
+package(default_applicable_licenses = ["//:license"])
+
 # The actual test.  It tests whether the contents match a particular desired
 # "manifest", most notably with regards to file structure.
 py_test(

diff --git a/tests/rpm/tree_artifacts/BUILD b/tests/rpm/tree_artifacts/BUILD
@@ -36,6 +36,8 @@ load("@rules_python//python:defs.bzl", "py_test")
 # - Each file in a TreeArtifact is installed relative to its position in the
 #   TreeArtifact, which itself is relative to the desired install prefix.
 
+package(default_applicable_licenses = ["//:license"])
+
 # The actual test.  It tests whether the contents match a particular desired
 # "manifest", most notably with regards to file structure.
 py_test(

diff --git a/tests/tar/BUILD b/tests/tar/BUILD
@@ -21,6 +21,8 @@ load("//tests/util:defs.bzl", "directory", "fake_artifact")
 load("@rules_python//python:defs.bzl", "py_test")
 load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 
+package(default_applicable_licenses = ["//:license"])
+
 py_test(
     name = "archive_test",
     srcs = [

diff --git a/tests/testdata/utf8/BUILD b/tests/testdata/utf8/BUILD
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+package(default_applicable_licenses = ["//:license"])
+
 filegroup(
     name = "files",
     srcs = glob(["**"]),

diff --git a/tests/util/BUILD b/tests/util/BUILD
@@ -16,6 +16,8 @@
 
 load("@rules_python//python:defs.bzl", "py_binary")
 
+package(default_applicable_licenses = ["//:license"])
+
 licenses(["notice"])
 
 exports_files(["defs.bzl"])

diff --git a/tests/zip/BUILD b/tests/zip/BUILD
@@ -19,6 +19,8 @@ load("//tests/util:defs.bzl", "directory", "fake_artifact")
 load("@rules_python//python:defs.bzl", "py_test")
 load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 
+package(default_applicable_licenses = ["//:license"])
+
 licenses(["notice"])
 
 genrule(

diff --git a/toolchains/BUILD b/toolchains/BUILD
@@ -11,3 +11,17 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+package(default_applicable_licenses = ["//:license"])
+
+filegroup(
+    name = "standard_package",
+    srcs = glob([
+        "*",
+    ]),
+    visibility = ["//distro:__pkg__"],
+)
+
+exports_files(
+    glob(["*"]),
+    visibility = ["//visibility:public"],
+)
diff --git a/toolchains/git/BUILD b/toolchains/git/BUILD
@@ -25,6 +25,8 @@ Toolchains:
 
 load("//toolchains/git:git.bzl", "git_toolchain", "is_git_available")
 
+package(default_applicable_licenses = ["//:license"])
+
 filegroup(
     name = "standard_package",
     srcs = glob(["*"]),

diff --git a/toolchains/rpm/BUILD b/toolchains/rpm/BUILD
@@ -26,6 +26,8 @@ Toolchains:
 
 load("//toolchains/rpm:rpmbuild.bzl", "is_rpmbuild_available", "rpmbuild_toolchain")
 
+package(default_applicable_licenses = ["//:license"])
+
 filegroup(
     name = "standard_package",
     srcs = glob([