Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into repo-mapping support #769

Closed
aiuto opened this issue Oct 30, 2023 · 0 comments · Fixed by #878
Closed

Look into repo-mapping support #769

aiuto opened this issue Oct 30, 2023 · 0 comments · Fixed by #878
Labels
feature-request P3 An issue that we are not working on but will review quarterly

Comments

@aiuto
Copy link
Collaborator

aiuto commented Oct 30, 2023

Context: bazelbuild/bazel#19937
bazelbuild/bazel#19944

Under bzlmod, paths to files in external repos changed. It may be difficult for users to write rules to rebase files from external repos to new locations. No time to write more details today, but I want this placeholder issue to point to the problem and the fix.
@aiuto aiuto added feature-request P3 An issue that we are not working on but will review quarterly labels Oct 30, 2023
lamcw added a commit to lamcw/rules_pkg that referenced this issue Jul 25, 2024
@lamcw
Add support for repo mapping
f69452f 
Esp. when include_runfiles = True

Closes bazelbuild#769

Signed-off-by: Thomas Lam <thomaslam@canva.com>
@lamcw lamcw mentioned this issue Jul 25, 2024
Merged
@aiuto aiuto closed this as completed in 447fb8e Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request P3 An issue that we are not working on but will review quarterly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for repo mapping lamcw/rules_pkg
1 participant
@aiuto