Add MODULE.bazel file #485
Conversation
| ) | ||
|
|
||
| bazel_dep(name = "rules_python", version = "0.4.0") | ||
| bazel_dep(name = "bazel_skylib", version = "1.0.3") |
There was a problem hiding this comment.
Can we make this float to head, or whatever whomever depends on rules_pkg wants to use?
There was a problem hiding this comment.
Are we able to say we depend on bazel 5.x?
|
Any update? |
[bzlmod] is the upcoming package manager for Bazel's external dependencies. While it's already in the [central registry], it's apparently also helpful to have such a file in the repository, in case, you need to use overrides. This change adds such a file, specifically the one from the central repository with the version bumped. I can't quite get the tests to work yet; I think there's a bug in how runfiles trees are created (the rule_python directory contains the version in addition to the name). [bzlmod]: https://docs.bazel.build/versions/main/bzlmod.html [central registry]: https://github.com/bazelbuild/bazel-central-registry
|
The tests are still failing with bzlmod enabled on the latest rolling release. Root cause looks to be something like what's in bazelbuild/bazel#14140, but I haven't had time to completely nail down the details. |
nacl
force-pushed
the
topic/module.bazel
branch
from
58f449a
to
6dbf3c1
Compare
|
BTW these problems might not affect users of rules_pkg, but they definitely prevent us from using it ourselves. |
|
Can we check in the module definition but not use it in our CI? I don't see any need to use it ourselves, but we can give others a leg up on trying it. Perhaps they will shake out any issues in the declaration. |
Absolutely. I'll see about doing this when I have an opportunity. |
|
I've taken this up in #625. |
|
Closing this since I got an initial MODULE set up. There is more to learn, but we can work from that. |
bzlmod is the upcoming package manager for Bazel's external dependencies.
While it's already in the central registry, it's apparently also helpful to
have such a file in the repository, in case, you need to use overrides.
This change adds such a file, specifically the one from the central repository
with the version bumped.
I can't quite get the tests to work yet; I think there's a bug in how runfiles
trees are created (the rules_python directory for the runfiles lib contains the
version in addition to the name). This was tested using the latest 5.0 RC; I
currently cannot test at bazel HEAD due to bazelbuild/bazel#14403.