Add artifact_name to print_relnotes

[aiuto]

This allows you to use artifact names that do not follow the standard convention.

Fixes #435

[aiuto]

@guw

[guw]

@aiuto just got to testing this with main branch but it doesn't seem to work. I still don't get the proper download url generated into http_archive

[aiuto]

Can you include a BUILD file snippet so I can make sure that you and I are doing the same thing.

…

On Sat, Mar 12, 2022 at 11:18 AM Gunnar Wagenknecht < ***@***.***> wrote: @aiuto <https://github.com/aiuto> just got to testing this with main branch but it doesn't seem to work. I still don't get the proper download url generated into http_archive — Reply to this email directly, view it on GitHub <#541 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHEING4Q5DW7MC4JOB3U7S7W3ANCNFSM5OKHR4UA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[guw]

@aiuto BUILD file is here: https://github.com/salesforce/bazel-jdt-java-toolchain/blob/07571cc819ecd76fff2908aaad2fb9a07034cef7/dist/BUILD#L30

My goal is to build rules_jdt.tar.gz and publish this.
bazel build //dist:rules_jdt produces bazel-bin/dist/rules_jdt.tar.gz

print_rel_notes(
    name = "relnotes",
     ...
    artifact_name = "rules_jdt.tar.gz",
    version = "latest",
)

When I run cat bazel-bin/dist/relnotes.txt is still uses https://github.com/salesforce/bazel-jdt-java-toolchain/releases/download/latest/bazel-jdt-java-toolchain-latest.tar.gz as the tar.

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "bazel_jdt_java_toolchain",
    urls = [
        "https://github.com/salesforce/bazel-jdt-java-toolchain/releases/download/latest/bazel-jdt-java-toolchain-latest.tar.gz",
    ],
    sha256 = "38d38804d88123a8661e1421fd9962e47891ced795c2350bd9ae7a2f3624c7d4",
)
load("@bazel_jdt_java_toolchain//jdt:repositories.bzl", "rules_jdt_dependencies", "rules_jdt_toolchains")
rules_jdt_dependencies()
rules_jdt_toolchains()

However, it looks like the sha256 is actually correct, i.e

shasum -a 256 bazel-bin/dist/rules_jdt.tar.gz
38d38804d88123a8661e1421fd9962e47891ced795c2350bd9ae7a2f3624c7d4  bazel-bin/dist/rules_jdt.tar.gz

Could this be a display issue of the release notes template file?

[guw]

@aiuto #561

[aiuto]

Thanks for the PR. I edited the title and description a bit to be more specific about why the fix was needed. I believe PR descriptions should be mostly self contained and not require one to know context from a bug conversation.

…

On Sun, Mar 13, 2022 at 5:19 AM Gunnar Wagenknecht ***@***.***> wrote: @aiuto <https://github.com/aiuto> #561 <#561> — Reply to this email directly, view it on GitHub <#541 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHH57MP7THG6WW3ENNTU7WXK5ANCNFSM5OKHR4UA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>